Various fixes and improvements #8494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
|
Okay to test. Contributor agreement on file. Thank you @Frauschi |
|
Rebased to current master to fix the mosquitto cert problem. I cannot reproduce the other failing tests on my side, any hints there? |
|
Retest this please: "Found unhandled hudson.remoting.RequestAbortedException exception:" |
Can you give more details on this? |
A rebase for PR #8496 is meant, as the expired cert caused a failing test in this PR. |
anhu
previously approved these changes
Feb 25, 2025
Thank you!! |
dgarske
requested changes
Feb 25, 2025
Some fixes to better handle Dilithium keys and signatures in the TLS handshake. Signed-off-by: Tobias Frauenschläger <[email protected]>
Add context and preHash metadata. Signed-off-by: Tobias Frauenschläger <[email protected]>
* Add support for CMake * Add support for Zephyr * Make sure the internal key state is properly handled in case a public key is imported into a reloaded private key. Signed-off-by: Tobias Frauenschläger <[email protected]>
Fix compilation in case caching is enabled. Signed-off-by: Tobias Frauenschläger <[email protected]>
Fix compilation in case PSK is enabled, not Session tickets are disabled. Signed-off-by: Tobias Frauenschläger <[email protected]>
Make sure peer dilithium keys are properly freed. Signed-off-by: Tobias Frauenschläger <[email protected]>
|
Retest this please. Some of the tests were aborted? |
dgarske
approved these changes
Feb 26, 2025
SparkiDev
approved these changes
Feb 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi all,
this PR adds various smaller fixes and improvements I encountered: